Replace got
in update-check to prevent CLI crash
#20693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
What's changed:
got
when previously cached response gets revalidated: Hangs on revalidated response from cache sindresorhus/got#2317update-check
which is performed when spawning the Directus CLI usesgot
to fetch the information from the NPM registry and caches the responsegot
correctly revalidates the response but then hangs indefinitely which is detected by Node.js and as a consequence Node.js terminates the process (exit code 13, unfinished top-level await)got
withaxios
in combination withaxios-cache-interceptor
Potential Risks / Drawbacks
I've successfully tested various scenarios, so this PR comes with minimal risk:
Review Notes / Questions
None