Fix SDK Tests #7469
Merged
Fix SDK Tests #7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `jest-environment-jsdom-global` didn't seem to bring any used advantages over the default `jest-environment-node`
|
Thank you, @rmcfadzean!! 鉂わ笍 |
rijkvanzanten
approved these changes
Aug 19, 2021
jamescammarano
approved these changes
Aug 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6543
Changed
PATCHtoPOSTfor invite accept testThis seems like it may have just been an oversight from awhile back. Simple fix.
Replaced
jest-environment-jsdom-globalwithjest-environment-jsdomThis wasn't strictly essential but saves an abstraction/package that isn't really required.
quick polyfill of
clearImmediateclearImmediateisn't part ofjest-environment-jsdom(jestjs/jest#11222) anymore so I used the versions from thetimerspackage.Removed
mockdateThis was causing some issues due to the way it overwrites the
Dateglobal.Example: boblauer/MockDate#46
Use
jest.useFakeTimersinsteadJest 27 changed the default behaviour for
jest.useFakeTimersto themodernimplementation which is based on @sinonjs/fake-timers (formerlylolex).This was causing timeouts with
nocknot executing responses (see: nock/nock#2200).The
flushfunction was updated to fix this by callingjest.runAllTicksas well as the promise flush.Let me know if you need any more info 馃殌