Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc #28

Merged
merged 1 commit into from Mar 4, 2022
Merged

Add doc #28

merged 1 commit into from Mar 4, 2022

Conversation

delphinus
Copy link
Collaborator

@delphinus delphinus commented Mar 3, 2022

I moved descriptions from README into doc. Now README has minimum description and users should read the detail in doc.

@delphinus
Copy link
Collaborator Author

@zimbatm Finally I added the Vim doc for here. The feature in #27 is also described in this.

@delphinus delphinus requested a review from zimbatm March 3, 2022 05:25

Environmental variable keys~

The Vimscript syntax seems to limit keys to alphanumeric characters. If any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If direnv/direnv#901 gets merged in, this limitation will no longer apply since it uses setenv(key,val). (But it's probably still worth having since that'll be a very new version of direnv)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It seems to need some logic to achieve Vim 8.0 compatibility which has no setenv(), I think.

Anyway, I will merge this PR with no change.

Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@delphinus delphinus merged commit 451e363 into master Mar 4, 2022
@delphinus delphinus deleted the feature/doc branch March 4, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants