Allow skipping .env autoload
#878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the contrib! |
|
I might switch the option around tomorrow to make it opt-in instead since it breaks back-compat. |
|
Personally I would prefer that, and thought about going that route with this PR, but didn't want to switch default behavior. |
|
Also would really like to make the |
|
my version is 2.30.3: but it still loads |
zimbatm
added a commit
to zimbatm/direnv
that referenced
this pull request
Mar 26, 2022
Loading the `.env` files is a change in behaviour and broke backward-compatibility. It sounds really nice at first but it turns out that many users have .env files littered in their repository and cause a direnv reload. It's possible to turn that feature off but now they have one extra step to instruct their users. This commit inverts the behaviour and turns that feature off by default to restore back-compat. See also direnv#878.
zimbatm
added a commit
to zimbatm/direnv
that referenced
this pull request
Mar 26, 2022
Loading the `.env` files is a change in behaviour and broke backward-compatibility. It sounds really nice at first but it turns out that many users have .env files littered in their repository and cause a direnv reload. It's possible to turn that feature off but now they have one extra step to instruct their users. This commit inverts the behaviour and turns that feature off by default to restore back-compat. See also direnv#878.
zimbatm
added a commit
that referenced
this pull request
Mar 26, 2022
Loading the `.env` files is a change in behaviour and broke backward-compatibility. It sounds really nice at first but it turns out that many users have .env files littered in their repository and cause a direnv reload. It's possible to turn that feature off but now they have one extra step to instruct their users. This commit inverts the behaviour and turns that feature off by default to restore back-compat. See also #878.
|
Sorry for the back and forth, #911 now inverts the config so that feature isn't enable by default anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature to automatically load .env files in #845 is nice, but it's a little too greedy in certain situations. Allow skipping that behavior by default (going back to explicit
dotenvcalls in.envrcfiles) in the configuration toml file.