Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch default back to not load dotenv files #894

Closed
wants to merge 1 commit into from
Closed

Switch default back to not load dotenv files #894

wants to merge 1 commit into from
+9 −0

Conversation

aneeshusa
Copy link
Contributor

Follow-up on #878 (comment).

@aneeshusa
Copy link
Contributor Author

Happy to adjust the code as desired (e.g. new option name or anything else), just wanted to put this up for consideration as a permanent change. If the plan is to keep/make config.SkipDotenv = false as the default in e.g. the next major release, then I don't think this PR is useful to temporarily add back-compat.

@zimbatm
Copy link
Member

zimbatm commented Mar 26, 2022

Thanks, I fixed it in #911

@zimbatm zimbatm closed this Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aneeshusa @zimbatm