This repository has been archived by the owner on Aug 28, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
added
Type: Enhancement
Issues and PRs related to feature enhancement.
Status: Help Wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
Meta: Refactor
Issues and PRs related to refactors.
SEM: Major
PRs that contain breaking changes and should be released in the next major version.
Meta: BugFix
PRs that fix bugs or issues.
Meta: Dependencies
Issues and PRs related to dependencies.
Status: Needs Testing
PRs that need testing from the author or volunteers.
Meta: Cleanup
Issues and PRs related to code cleanup.
Mod: SettingsGateway
Issues and PRs related to SettingsGateway.
Meta: Typings
Issues and PRs related to typings.
labels
Nov 11, 2019
This comment has been minimized.
This comment has been minimized.
kyranet
removed
the
Status: Help Wanted
Issues that need assistance from volunteers or PRs that need help to proceed.
label
Jan 2, 2020
kyranet
force-pushed
the
wipe-settings
branch
7 times, most recently
from
January 2, 2020 23:28
4bf89b9
to
8772410
Compare
PyroTechniac
approved these changes
Jan 9, 2020
PyroTechniac
approved these changes
Jan 9, 2020
PyroTechniac
suggested changes
Jan 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through it a second time and found a few things
Co-Authored-By: Gryffon Bellish <owenbellish@gmail.com>
PyroTechniac
suggested changes
Jan 12, 2020
Co-Authored-By: Gryffon Bellish <owenbellish@gmail.com>
PyroTechniac
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Superseded by #916 to move the base branch into this repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Meta: BugFix
PRs that fix bugs or issues.
Meta: Cleanup
Issues and PRs related to code cleanup.
Meta: Dependencies
Issues and PRs related to dependencies.
Meta: Refactor
Issues and PRs related to refactors.
Meta: Typings
Issues and PRs related to typings.
Mod: SettingsGateway
Issues and PRs related to SettingsGateway.
SEM: Major
PRs that contain breaking changes and should be released in the next major version.
Status: Needs Testing
PRs that need testing from the author or volunteers.
Type: Enhancement
Issues and PRs related to feature enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Prepares klasa for
@klasa/settings-gateway
.Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)
Added
null
as an option to reset a key inSettingsFolder
#{update
}.Serializer
#{validate
,resolve
} to allow further control on how SettingsGateway handles the data.context
to thesettingsUpdate
andsettingsCreate
events, they contain the raw changes, guild, language, etc.extraContext
to theSettingsFolderResetOptions
type, this value is pased in all places (Serializer
#validate
,SchemaEntry
#filter
,settingsUpdate
andsettingsCreate
events, and more).Changed
Serializer
#stringify
's second argument fromKlasaMessage
toGuild | null
.Serializer
#deserialize
's arguments to (SerializableValue
,SerializerUpdateContext
).SchemaEntry
#{min
,max
} toSchemaEntry
#{minimum
,maximum
}.SettingsFolder
's value type to be more accurate.SettingsFolderUpdateOptions
's option to produce a TypeScript compiler error whenarrayAction
is set to'overwrite'
andarrayIndex
is defined.SettingsFolder
#client
to throw an error when it's uninitialized.SettingsFolder
#{reset
,update
} to return a much more useful struct.arrayIndex
inSettingsFolder
#update
andarrayAction
is defined asadd
, all entries will be inserted at given index.arrayIndex
inSettingsFolder
#update
andarrayAction
is defined asremove
, as many entries as given will be removed from given index.arrayIndex
inSettingsFolder
#update
andarrayAction
is not defined or defined asauto
, all entries will replace the existing ones.Removed
throwOnError
option inSettingsFolder
#{reset
,update
}, they will now always throw when they encounter an error.Fixed
Schema
#get
would throw an error if a path did not exist.Schema
#{add
,remove
} was still callable even after being initialized.SettingsFolder
#get
would throw an error if a path did not exist.SettingsFolder
#pluck
.SettingsFolder
#resolve
not resolving into objects when specifying a folder path.SettingsFolder
#reset
where database conditions were not handled correctly.SettingsFolder
#update
where options would sometimes type error.SettingsFolder
's patch function not allowing non-literal objects to be used.SettingsFolder
#{reset
,update
} patching after emit.Provider
andSQLProvider
classes.Semver Classification