V4: State and Cache providers #2251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cachable models so far - Users - Presence
quinchs
requested review from
csmir,
Auralytical,
Cenngo,
lhjt and
MrCakeSlayer
Cenngo
reviewed
Apr 24, 2022
|
|
||
| namespace Discord | ||
| { | ||
| internal static class CacheableEntityExtensions |
There was a problem hiding this comment.
Is there any reason why these methods arent returning the generic type parameters? We could downcast it later.
There was a problem hiding this comment.
Not really, its just whats there atm. it could change once I implement the rest of the entities
Cenngo
approved these changes
Apr 24, 2022
Co-authored-by: Jared L <48422312+lhjt@users.noreply.github.com>
Co-authored-by: Jared L <48422312+lhjt@users.noreply.github.com>
MrCakeSlayer
approved these changes
Jun 1, 2022
|
Is this still on the roadmap? I'm building something and using this library but running into a few limitations that I need to work around. I left my comments in this discussion here: thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements state and cache providers as proposed in #2238.
The current api of the providers is up for debate, I've implemented it how I see fit but feedback and reviews are always welcome.
Todo: