Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Carbon library #1222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade Carbon library #1222

wants to merge 2 commits into from

Conversation

Korbeil
Copy link
Contributor

@Korbeil Korbeil commented May 6, 2024

Follow-up from #1213

This PR is required for Symfony 7 support

SQKo
SQKo requested changes May 8, 2024
View reviewed changes
Copy link
Member

@SQKo SQKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add back v2? This branch minimum php version is still php8.0 not php8.1

@Korbeil
Copy link
Contributor Author

Korbeil commented May 8, 2024

Can you please add back v2? This branch minimum php version is still php8.0 not php8.1

Not sure to understand what you're asking me ? You mean doing an OR ? Like ^2.38 || ^3.0 ?

@SQKo
Copy link
Member

SQKo commented May 8, 2024

Can you please add back v2? This branch minimum php version is still php8.0 not php8.1

Not sure to understand what you're asking me ? You mean doing an OR ? Like ^2.38 || ^3.0 ?

Yes

@Korbeil
Copy link
Contributor Author

Korbeil commented May 8, 2024

@SQKo fixed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SQKo SQKo SQKo requested changes

@valzargaming valzargaming valzargaming approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Korbeil @SQKo @valzargaming