Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate ESlint to flat config #6834

Merged
merged 3 commits into from
May 15, 2024
Merged

chore: Migrate ESlint to flat config #6834

merged 3 commits into from
May 15, 2024

Conversation

codershiba
Copy link
Contributor

No description provided.

JustinBeckwith
JustinBeckwith requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! It looks like npm is angry is though. Mind double checking npm install?

@JustinBeckwith JustinBeckwith self-assigned this May 14, 2024
@JustinBeckwith JustinBeckwith added the waiting for response Discord is waiting for a response and will re-triage the issue at a later point label May 14, 2024
@JustinBeckwith
Copy link
Contributor

@codershiba this is still messed up. Note: we are using npm ci instead of npm install in CI, so it's going to get exactly what's in package-lock.json. This may be one of those cases where it makes sense to delete package-lock.json, run npm install, and get a fresh one as part of your changes.

@codershiba
Copy link
Contributor Author

I think it should be resolved now, doesn't seem to error anymore.

JustinBeckwith
JustinBeckwith approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@JustinBeckwith JustinBeckwith merged commit e8e1468 into discord:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees

@JustinBeckwith JustinBeckwith

Labels
waiting for response Discord is waiting for a response and will re-triage the issue at a later point
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codershiba @JustinBeckwith