feat: cli draft #3255
Draft
feat: cli draft #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3255 +/- ##
==========================================
- Coverage 77.00% 76.32% -0.69%
==========================================
Files 186 189 +3
Lines 22108 22306 +198
Branches 721 721
==========================================
Hits 17025 17025
- Misses 5071 5269 +198
Partials 12 12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Skillz4Killz
reviewed
Dec 7, 2023
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
should this be in the repo? also i thought we wanted to go with discordeno.config.js file name?
| @@ -0,0 +1,142 @@ | |||
| const messageTypeProps = { | |||
There was a problem hiding this comment.
is this autogenerated or manually created? if autogenerated it shouldnt be in the repo, if manual, im not a fan of having this written twice here.
| @@ -0,0 +1,5 @@ | |||
| export interface DiscordenoConfig { | |||
| desiredProps: { | |||
| message: string[] | |||
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR generates a message type file from the .discordenorc.json config file.
The type file is located at
node_modules/.discordeno/transformer/src