Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

style: improve error messages #61

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Khasms
Copy link
Contributor

@Khasms Khasms commented Dec 11, 2021

Please describe the changes this PR makes and why it should be merged:
Currently, when the name regex validation fails, the error message is just Invalid and doesn't say what's wrong. This PR adds a custom error message to give some more information in that scenario.

Edit: Added more error messages to help with issues like #64.

Status and versioning classification:

  • Code changes have been tested, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@codecov-commenter
Copy link

Codecov Report

Merging #61 (be10850) into main (0263f00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #61   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          276       276           
  Branches        37        37           
=========================================
  Hits           276       276           
Impacted Files Coverage Δ
src/interactions/contextMenuCommands/Assertions.ts 100.00% <ø> (ø)
src/interactions/slashCommands/Assertions.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0263f00...be10850. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants