Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(SlashCommands): add attachment option #65

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amitojsingh366
Copy link

@amitojsingh366 amitojsingh366 commented Dec 17, 2021

Please describe the changes this PR makes and why it should be merged:
This PR adds the ability to add an attachment option to slash commands

Status and versioning classification:
This PR relies on discordjs/discord-api-types#272 and discord/discord-api-docs#4253

NOTE: this is my first time contributing to this project so if anything is wrong please do tell me

__tests__/SlashCommands.test.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #65 (ebfb69d) into main (0263f00) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #65   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        22    +1     
  Lines          276       279    +3     
  Branches        37        37           
=========================================
+ Hits           276       279    +3     
Impacted Files Coverage Δ
...nteractions/slashCommands/mixins/CommandOptions.ts 100.00% <100.00%> (ø)
...c/interactions/slashCommands/options/attachment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0263f00...ebfb69d. Read the comment docs.

@amitojsingh366
Copy link
Author

the workflow will error on this PR until discordjs/discord-api-types#272 is merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants