Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ApplicationCommand): attachment application command option type #272

Merged
merged 6 commits into from Feb 9, 2022

Conversation

amitojsingh366
Copy link
Contributor

@amitojsingh366 amitojsingh366 commented Dec 17, 2021

Please describe the changes this PR makes and why it should be merged:
This pr adds the types for the ATTACHMENT application command option type

Reference Discord API Docs PRs or commits:
this PR relies on discord/discord-api-docs#4253

NOTE: this is my first time contributing to this project so if anything is wrong please do tell me

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to rerun the build:deno script

@amitojsingh366
Copy link
Contributor Author

You may want to rerun the build:deno script

I get no output:
Screen Shot 2022-01-02 at 10 27 10 PM

@vladfrangu
Copy link
Member

You're not gonna get output from the script, but you'll get changed files

@amitojsingh366
Copy link
Contributor Author

You're not gonna get output from the script, but you'll get changed files

Oh ok, my commit was made after the command so I missed what changed. But ig as long as it didn't error it's fine right?

@Smidul
Copy link

Smidul commented Feb 9, 2022

Upstream PR merged 🍕

@vladfrangu vladfrangu changed the title feat(ApplicationCommands): attachment application command option type feat(ApplicationCommand): attachment application command option type Feb 9, 2022
@vladfrangu vladfrangu merged commit 71c4e6a into discordjs:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants