Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change resolved index types to string #169

Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix: change resolved index types to string #169

merged 1 commit into from
Jul 26, 2021

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jul 26, 2021 •
edited

this lets you access resolved fields using ts 4.3.

this should be reverted once ts 4.4 releases (august 24)

vladfrangu
vladfrangu approved these changes Jul 26, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks TypeScript.

@vladfrangu vladfrangu merged commit d338409 into discordjs:main Jul 26, 2021
@advaith1 advaith1 deleted the resolved-indexes branch July 26, 2021 23:32
vladfrangu added a commit that referenced this pull request Jul 30, 2021
@vladfrangu
Revert "fix: change resolved index types to string (#169)"
25b89d4 
This reverts commit d338409.
@vladfrangu vladfrangu mentioned this pull request Jul 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@advaith1 @vladfrangu