Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add guild scheduled event #186

Merged
merged 17 commits into from
Nov 25, 2021
Merged

feat: add guild scheduled event #186

merged 17 commits into from
Nov 25, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Aug 22, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

Adds type definitions for Guild Scheduled Event

Reference Discord API Docs PRs or commits:

@iShibi iShibi mentioned this pull request Oct 1, 2021
Closed
@iShibi iShibi changed the title feat: add guild event feat: add guild scheduled event Nov 17, 2021
@iShibi iShibi marked this pull request as ready for review November 17, 2021 06:57
@iShibi
Copy link
Contributor Author

iShibi commented Nov 17, 2021

This is ready for review. Once it is released the typings error will be gone in discordjs/discord.js#6943

vladfrangu
vladfrangu requested changes Nov 17, 2021
View reviewed changes
gateway/v8.ts Outdated Show resolved Hide resolved
gateway/v9.ts Outdated Show resolved Hide resolved
payloads/v8/auditLog.ts Outdated Show resolved Hide resolved
payloads/v8/auditLog.ts Outdated Show resolved Hide resolved
payloads/v8/guildScheduledEvent.ts Outdated Show resolved Hide resolved
payloads/v8/invite.ts Outdated Show resolved Hide resolved
payloads/v9/auditLog.ts Outdated Show resolved Hide resolved
payloads/v9/auditLog.ts Show resolved Hide resolved
payloads/v9/guildScheduledEvent.ts Outdated Show resolved Hide resolved
payloads/v9/invite.ts Outdated Show resolved Hide resolved
@iShibi
Copy link
Contributor Author

iShibi commented Nov 19, 2021

Added new upstream changes:

@iShibi iShibi mentioned this pull request Nov 19, 2021
Merged
18 tasks
@iShibi
Copy link
Contributor Author

iShibi commented Nov 19, 2021

Added some more changes:

vladfrangu
vladfrangu requested changes Nov 22, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, if you can apply this for deno as well, we can get this merged

rest/common.ts Outdated Show resolved Hide resolved
iShibi and others added 2 commits November 23, 2021 06:02
@vladfrangu
Copy link
Member

@iShibi can you confirm that this is everything, so I can get this merged? If there are changes after merge, feel free to PR them :D

@iShibi
Copy link
Contributor Author

iShibi commented Nov 25, 2021

@vladfrangu Yup, everything that has been merged is here. The only thing that's left is this:

@vladfrangu
Copy link
Member

I'm going to merge this as is to finally actually release 0.25.0 (a month of changes...wooo) so you'll have to PR audit log stuffs when they merge. Worst case I'll do a quick 0.25.1 for that

@vladfrangu vladfrangu merged commit d333962 into discordjs:main Nov 25, 2021
@iShibi iShibi deleted the guild-event branch January 12, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iShibi @vladfrangu @kyranet