Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(APIGroupDMChannel): make name nullable #347

Merged
merged 1 commit into from
Mar 29, 2022
Merged

refactor(APIGroupDMChannel): make name nullable #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion deno/payloads/v10/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ interface APIDMChannelBase<T extends ChannelType> extends APITextBasedChannel<T>

export type APIDMChannel = APIDMChannelBase<ChannelType.DM>;

export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM> {
export interface APIGroupDMChannel extends Omit<APIDMChannelBase<ChannelType.GroupDM>, 'name'> {
vladfrangu marked this conversation as resolved.
Show resolved Hide resolved
/**
* Application id of the group DM creator if it is bot-created
*/
Expand All @@ -174,6 +174,10 @@ export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM>
* Icon hash
*/
icon?: string | null;
/**
* The name of the channel (2-100 characters)
*/
name?: string | null;
/**
* ID of the DM creator
*/
Expand Down
6 changes: 5 additions & 1 deletion deno/payloads/v9/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ interface APIDMChannelBase<T extends ChannelType> extends APITextBasedChannel<T>

export type APIDMChannel = APIDMChannelBase<ChannelType.DM>;

export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM> {
export interface APIGroupDMChannel extends Omit<APIDMChannelBase<ChannelType.GroupDM>, 'name'> {
/**
* Application id of the group DM creator if it is bot-created
*/
Expand All @@ -174,6 +174,10 @@ export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM>
* Icon hash
*/
icon?: string | null;
/**
* The name of the channel (2-100 characters)
*/
name?: string | null;
/**
* ID of the DM creator
*/
Expand Down
6 changes: 5 additions & 1 deletion payloads/v10/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ interface APIDMChannelBase<T extends ChannelType> extends APITextBasedChannel<T>

export type APIDMChannel = APIDMChannelBase<ChannelType.DM>;

export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM> {
export interface APIGroupDMChannel extends Omit<APIDMChannelBase<ChannelType.GroupDM>, 'name'> {
/**
* Application id of the group DM creator if it is bot-created
*/
Expand All @@ -174,6 +174,10 @@ export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM>
* Icon hash
*/
icon?: string | null;
/**
* The name of the channel (2-100 characters)
*/
name?: string | null;
/**
* ID of the DM creator
*/
Expand Down
6 changes: 5 additions & 1 deletion payloads/v9/channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ interface APIDMChannelBase<T extends ChannelType> extends APITextBasedChannel<T>

export type APIDMChannel = APIDMChannelBase<ChannelType.DM>;

export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM> {
export interface APIGroupDMChannel extends Omit<APIDMChannelBase<ChannelType.GroupDM>, 'name'> {
/**
* Application id of the group DM creator if it is bot-created
*/
Expand All @@ -174,6 +174,10 @@ export interface APIGroupDMChannel extends APIDMChannelBase<ChannelType.GroupDM>
* Icon hash
*/
icon?: string | null;
/**
* The name of the channel (2-100 characters)
*/
name?: string | null;
/**
* ID of the DM creator
*/
Expand Down