-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: user-installable apps #921
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- integration_types is always optional - contexts is always optional - contexts is nullable except when creating or editing an application command
The last issue just got resolved. 👀 |
- Remove non-string value in `authorizing_integration_owners` - Preserve documentation for `contexts` - `APIMessageInteractionMetadata` `user_id` -> `user`
Types now match the API and docs. I'm unsure if this should be merged (as the docs say: "API details are subject to change.") but I'll leave it up to the maintainers to decide. If not yet, I'll keep this updated with changes. |
You can mark it as |
@AtoraSuunva boop, do you have some time, or would you like some help with this? |
@vladfrangu oops, got busy with some things. Used discord/discord-api-docs#6782 as reference for what to mark as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an API v10 only feature? If yes, please let us know! If not, ctrl c ctrl v in api v9 too please
Seems to work even all the way back to v6, both REST requests and gateway. Only added it to v9 for now though. |
Lets see if crap hits the fan >:3 |
Please describe the changes this PR makes and why it should be merged:
Adds in the new fields & deprecation changes from https://discord.com/developers/docs/change-log#userinstallable-apps-preview
Now you can make user-installable apps with type-safety :)
Marked as draft until these issues are resolved, since what the API returns and what the docs say is different (current PR matches the API, will update based on issues):
integration_types
andcontexts
are both documented as non-nullable with defaults, butcontexts
can benull
discord/discord-api-docs#6744authorizing_integration_owners
discord/discord-api-docs#6730If applicable, please reference Discord API Docs PRs or commits that influenced this PR: