Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat(SequentialHandler): add more info to debug when rate limit was hit #78

Merged
merged 1 commit into from Dec 8, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Oct 31, 2021

Please describe the changes this PR makes and why it should be merged:

Ported from discordjs/discord.js#5801

Needs #77

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #78 (750f18e) into main (c22081d) will decrease coverage by 0.09%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   89.03%   88.94%   -0.10%     
==========================================
  Files           9        9              
  Lines        1487     1492       +5     
  Branches      153      155       +2     
==========================================
+ Hits         1324     1327       +3     
  Misses         12       12              
- Partials      151      153       +2     
Impacted Files Coverage Δ
...ackages/rest/src/lib/handlers/SequentialHandler.ts 82.19% <92.85%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22081d...750f18e. Read the comment docs.

@ckohen ckohen changed the title Add rl info feat(SequentialHandler): add more info to debug when rate limit wa shit Oct 31, 2021
@ckohen ckohen changed the title feat(SequentialHandler): add more info to debug when rate limit wa shit feat(SequentialHandler): add more info to debug when rate limit was hit Oct 31, 2021
@ckohen ckohen marked this pull request as ready for review December 2, 2021 23:03
@iCrawl iCrawl added this to In progress in REST via automation Dec 6, 2021
REST automation moved this from In progress to Review in progress Dec 6, 2021
REST automation moved this from Review in progress to Reviewer approved Dec 8, 2021
@iCrawl iCrawl merged commit a4e404b into discordjs:main Dec 8, 2021
REST automation moved this from Reviewer approved to Done Dec 8, 2021
@ckohen ckohen deleted the add-rl-info branch December 9, 2021 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants