Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

feat: expose https agent options #82

Merged
merged 1 commit into from Nov 17, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Nov 14, 2021

Please describe the changes this PR makes and why it should be merged:

Ported from discordjs/discord.js#6177

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Ported from discordjs/discord.js#6177

Co-authored-by: Shino <shinotheshino@gmail.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #82 (030aa77) into main (6df603e) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   88.83%   88.91%   +0.07%     
==========================================
  Files           8        8              
  Lines        1344     1353       +9     
  Branches      142      142              
==========================================
+ Hits         1194     1203       +9     
  Misses          9        9              
  Partials      141      141              
Impacted Files Coverage Δ
packages/rest/src/lib/REST.ts 96.27% <100.00%> (+0.10%) ⬆️
packages/rest/src/lib/RequestManager.ts 93.92% <100.00%> (+0.03%) ⬆️
packages/rest/src/lib/utils/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df603e...030aa77. Read the comment docs.

@iCrawl iCrawl added this to In progress in REST via automation Nov 14, 2021
REST automation moved this from In progress to Reviewer approved Nov 15, 2021
@iCrawl iCrawl merged commit 7f1c9be into discordjs:main Nov 17, 2021
REST automation moved this from Reviewer approved to Done Nov 17, 2021
@ckohen ckohen deleted the expose-agent-options branch November 17, 2021 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants