Skip to content
This repository has been archived by the owner on Jan 8, 2022. It is now read-only.

chore(RequestManager): use new file upload format #88

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

ckohen
Copy link
Member

@ckohen ckohen commented Dec 7, 2021

Please describe the changes this PR makes and why it should be merged:

Ported from discordjs/discord.js#6871

Co-authored-by: Jake Ward geek@gaminggeek.dev

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

Ported from discordjs/discord.js#6871

Co-authored-by: Jake Ward <geek@gaminggeek.dev>
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #88 (3b9eca2) into main (c22081d) will decrease coverage by 0.11%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   89.03%   88.91%   -0.12%     
==========================================
  Files           9        9              
  Lines        1487     1489       +2     
  Branches      153      155       +2     
==========================================
  Hits         1324     1324              
  Misses         12       12              
- Partials      151      153       +2     
Impacted Files Coverage Δ
packages/rest/src/lib/RequestManager.ts 93.42% <60.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22081d...3b9eca2. Read the comment docs.

@iCrawl iCrawl added this to In progress in REST via automation Dec 7, 2021
REST automation moved this from In progress to Reviewer approved Dec 7, 2021
@iCrawl iCrawl merged commit 8ba5374 into discordjs:main Dec 7, 2021
REST automation moved this from Reviewer approved to Done Dec 7, 2021
@ckohen ckohen deleted the new-upload-format branch December 7, 2021 20:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
REST
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants