chore: make requested changes

discordjs · Nov 26, 2022 · 1c3672c · 1c3672c
1 parent 37cfe43
commit 1c3672c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/packages/discord.js/src/structures/ApplicationCommand.js b/packages/discord.js/src/structures/ApplicationCommand.js
@@ -52,6 +52,12 @@ class ApplicationCommand extends Base {
      */
     this.type = data.type;
 
+    /**
+     * Whether this command is age-restricted (18+)
+     * @type {boolean}
+     */
+    this.nsfw = data.nsfw ?? false;
+
     this._patch(data);
   }
 
@@ -152,16 +158,6 @@ class ApplicationCommand extends Base {
        */
       this.version = data.version;
     }
-
-    if ('nsfw' in data) {
-      /**
-       * Whether this command is NSFW
-       * @type {?boolean}
-       */
-      this.nsfw = data.nsfw;
-    } else {
-      this.nsfw ??= null;
-    }
   }
 
   /**

diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts
@@ -419,7 +419,7 @@ export class ApplicationCommand<PermissionsFetchType = {}> extends Base {
   >;
   public type: ApplicationCommandType;
   public version: Snowflake;
-  public nsfw: boolean | null;
+  public nsfw: boolean;
   public delete(): Promise<ApplicationCommand<PermissionsFetchType>>;
   public edit(data: Partial<ApplicationCommandData>): Promise<ApplicationCommand<PermissionsFetchType>>;
   public setName(name: string): Promise<ApplicationCommand<PermissionsFetchType>>;
@@ -4166,6 +4166,7 @@ export interface BaseApplicationCommandData {
   nameLocalizations?: LocalizationMap;
   dmPermission?: boolean;
   defaultMemberPermissions?: PermissionResolvable | null;
+  nsfw?: boolean;
 }
 
 export interface AttachmentData {
@@ -4216,7 +4217,6 @@ export interface ChatInputApplicationCommandData extends BaseApplicationCommandD
   descriptionLocalizations?: LocalizationMap;
   type?: ApplicationCommandType.ChatInput;
   options?: ApplicationCommandOptionData[];
-  nsfw?: boolean;
 }
 
 export type ApplicationCommandData =