fix(ApplicationCommandManager): allow passing 0n to defaultMemberPerm…

…issions (#8311) * fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions * fix(ApplicationCommand): equals()
discordjs · Jul 20, 2022 · 1fb7b30 · 1fb7b30
1 parent 45c9659
commit 1fb7b30
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/discord.js/src/managers/ApplicationCommandManager.js b/packages/discord.js/src/managers/ApplicationCommandManager.js
@@ -242,9 +242,10 @@ class ApplicationCommandManager extends CachedManager {
     }
 
     if ('defaultMemberPermissions' in command) {
-      default_member_permissions = command.defaultMemberPermissions
-        ? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString()
-        : command.defaultMemberPermissions;
+      default_member_permissions =
+        command.defaultMemberPermissions !== null
+          ? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString()
+          : command.defaultMemberPermissions;
     }
 
     return {

diff --git a/packages/discord.js/src/structures/ApplicationCommand.js b/packages/discord.js/src/structures/ApplicationCommand.js
@@ -365,9 +365,10 @@ class ApplicationCommand extends Base {
     }
 
     if ('defaultMemberPermissions' in command) {
-      defaultMemberPermissions = command.defaultMemberPermissions
-        ? new PermissionsBitField(command.defaultMemberPermissions).bitfield
-        : null;
+      defaultMemberPermissions =
+        command.defaultMemberPermissions !== null
+          ? new PermissionsBitField(command.defaultMemberPermissions).bitfield
+          : null;
     }
 
     // Check top level parameters