refactor: add emoji string support for select menu options

packages/builders/src/components/selectMenu/UnsafeSelectMenuOption.ts

@@ -78,8 +78,8 @@ export class UnsafeSelectMenuOption {
 	}
 
 	/**
-	 * Sets the emoji to display on this button
-	 * @param emoji The emoji to display on this button
+	 * Sets the emoji to display on this option
+	 * @param emoji The emoji to display on this option
 	 */
 	public setEmoji(emoji: APIMessageComponentEmoji) {
 		this.data.emoji = emoji;

packages/discord.js/src/structures/SelectMenuOption.js

@@ -0,0 +1,20 @@
+'use strict';
+
+const { SelectMenuOption: BuildersSelectMenuOption } = require('@discordjs/builders');
+const Util = require('../util/Util');
+
+class SelectMenuOption extends BuildersSelectMenuOption {
+  /**
+   * Sets the emoji to display on this option
+   * @param {APIMessageComponentEmoji} emoji The emoji to display on this option
+   * @returns {SelectMenuOption}
+   */
+  setEmoji(emoji) {
+    if (typeof emoji === 'string') {
+      return super.setEmoji(Util.parseEmoji(emoji));
+    }
+    return super.setEmoji(emoji);
+  }
+}
+
+module.exports = SelectMenuOption;

packages/discord.js/typings/index.d.ts

@@ -18,6 +18,7 @@ import {
   quote,
   roleMention,
   SelectMenuComponent as BuilderSelectMenuComponent,
+  SelectMenuOption as BuildersSelectMenuOption,
   TextInputComponent as BuilderTextInputComponent,
   spoiler,
   strikethrough,
@@ -502,11 +503,11 @@ export class ButtonInteraction<Cached extends CacheType = CacheType> extends Mes
   public inRawGuild(): this is ButtonInteraction<'raw'>;
 }
 
-export type ComponentEmojiResolvable = APIMessageComponentEmoji | string;
+export type ComponentEmojiResolvable = APIMessageComponentEmoji | `<${'a' | ''}:${string}:${bigint}>`;
 
 export class ButtonComponent extends BuilderButtonComponent {
   public constructor(data?: ButtonComponentData | (Omit<APIButtonComponent, 'type'> & { type?: ComponentType.Button }));
-  public override setEmoji(emoji: string | ComponentEmojiResolvable): this;
+  public override setEmoji(emoji: ComponentEmojiResolvable): this;
 }
 
 export class SelectMenuComponent extends BuilderSelectMenuComponent {
@@ -515,6 +516,10 @@ export class SelectMenuComponent extends BuilderSelectMenuComponent {
   );
 }
 
+export class SelectMenuOption extends BuildersSelectMenuOption {
+  public setEmoji(emoji: ComponentEmojiResolvable): this;
+}
+
 export class TextInputComponent extends BuilderTextInputComponent {
   public constructor(data?: TextInputComponentData | APITextInputComponent);
 }
@@ -5294,7 +5299,6 @@ export {
 export {
   UnsafeButtonComponent,
   UnsafeSelectMenuComponent,
-  SelectMenuOption,
   UnsafeSelectMenuOption,
   MessageActionRowComponent,
   UnsafeEmbed,

packages/discord.js/typings/index.test-d.ts

@@ -1358,7 +1358,11 @@ new SelectMenuComponent({
 
 new ButtonComponent({
   style: ButtonStyle.Danger,
-});
+})
+  .setEmoji('<a:foo:123>')
+  .setEmoji('<:foo:123>')
+  // @ts-expect-error
+  .setEmoji(':foobar:123');
 
 // @ts-expect-error
 new Embed().setColor('abc');