Skip to content

Commit

Permalink
fix(GuildMemberManager): add() method throws an error (#8539)
Browse files Browse the repository at this point in the history
* fix(GuildMemberManager): `add()` method throws an error

* chore: update comment
  • Loading branch information
Syjalo committed Aug 21, 2022
1 parent 23a0b6c commit 3bef901
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions packages/discord.js/src/managers/GuildMemberManager.js
@@ -1,6 +1,5 @@
'use strict';

const { Buffer } = require('node:buffer');
const { setTimeout, clearTimeout } = require('node:timers');
const { Collection } = require('@discordjs/collection');
const { makeURLSearchParams } = require('@discordjs/rest');
Expand Down Expand Up @@ -128,8 +127,12 @@ class GuildMemberManager extends CachedManager {
resolvedOptions.roles = resolvedRoles;
}
const data = await this.client.rest.put(Routes.guildMember(this.guild.id, userId), { body: resolvedOptions });
// Data is an empty buffer if the member is already part of the guild.
return data instanceof Buffer ? (options.fetchWhenExisting === false ? null : this.fetch(userId)) : this._add(data);
// Data is an empty Uint8Array if the member is already part of the guild.
return data instanceof Uint8Array
? options.fetchWhenExisting === false
? null
: this.fetch(userId)
: this._add(data);
}

/**
Expand Down

0 comments on commit 3bef901

Please sign in to comment.