Skip to content

Commit

Permalink
fix(Typings): add missing typings for HttpError -> requestData (#…
Browse files Browse the repository at this point in the history
…5742)

Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
  • Loading branch information
casperiv0 and SpaceEEC committed Jun 3, 2021
1 parent 99e2ca4 commit 3e9ce35
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/rest/HTTPError.js
Expand Up @@ -42,8 +42,9 @@ class HTTPError extends Error {
/**
* The attachment data that is sent to Discord
* @typedef {Object} HTTPAttachmentData
* @property {string|Buffer|Stream} attachment The source of this attachment data
* @property {string} name The file name
* @property {Buffer} file The file buffer
* @property {Buffer|Stream} file The file buffer
*/

/**
Expand Down
17 changes: 15 additions & 2 deletions typings/index.d.ts
Expand Up @@ -703,13 +703,14 @@ declare module 'discord.js' {
}

export class DiscordAPIError extends Error {
constructor(path: string, error: unknown, method: string, httpStatus: number);
constructor(error: unknown, status: number, request: unknown);
private static flattenErrors(obj: unknown, key: string): string[];

public code: number;
public method: string;
public path: string;
public httpStatus: number;
public requestData: HTTPErrorData;
}

export class DMChannel extends TextBasedChannel(Channel, ['bulkDelete']) {
Expand Down Expand Up @@ -1045,11 +1046,12 @@ declare module 'discord.js' {
}

export class HTTPError extends Error {
constructor(message: string, name: string, code: number, method: string, path: string);
constructor(message: string, name: string, code: number, request: unknown);
public code: number;
public method: string;
public name: string;
public path: string;
public requestData: HTTPErrorData;
}

export class Integration extends Base {
Expand Down Expand Up @@ -3083,6 +3085,17 @@ declare module 'discord.js' {
cache?: boolean;
}

interface HTTPAttachmentData {
attachment: string | Buffer | Stream;
name: string;
file: Buffer | Stream;
}

interface HTTPErrorData {
json: unknown;
files: HTTPAttachmentData[];
}

interface HTTPOptions {
api?: string;
version?: number;
Expand Down

0 comments on commit 3e9ce35

Please sign in to comment.