fix(PermissionOverwriteManager): mutates user (#8282)

Fix PermissionOverwriteManager changing userOrRole Since it's mutated the original Member object won't be passed to upset and will be seen as invalid if User cache is disabled. Functions normally even with User cache disabled after the fix.
discordjs · Jul 17, 2022 · 4d86cf4 · 4d86cf4
1 parent beb3d8e
commit 4d86cf4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/managers/PermissionOverwriteManager.js b/src/managers/PermissionOverwriteManager.js
@@ -142,8 +142,9 @@ class PermissionOverwriteManager extends CachedManager {
    *   .catch(console.error);
    */
   edit(userOrRole, options, overwriteOptions) {
-    userOrRole = this.channel.guild.roles.resolveId(userOrRole) ?? this.client.users.resolveId(userOrRole);
-    const existing = this.cache.get(userOrRole);
+    const existing = this.cache.get(
+      this.channel.guild.roles.resolveId(userOrRole) ?? this.client.users.resolveId(userOrRole),
+    );
     return this.upsert(userOrRole, options, overwriteOptions, existing);
   }