Skip to content

Commit

Permalink
fix(Components): support emoji id strings (#8310)
Browse files Browse the repository at this point in the history
  • Loading branch information
advaith1 committed Jul 19, 2022
1 parent 70dd757 commit 660e212
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions packages/discord.js/src/structures/ButtonBuilder.js
Expand Up @@ -2,15 +2,15 @@

const { ButtonBuilder: BuildersButton, isJSONEncodable } = require('@discordjs/builders');
const { toSnakeCase } = require('../util/Transformers');
const { parseEmoji } = require('../util/Util');
const { resolvePartialEmoji } = require('../util/Util');

/**
* Represents a button builder.
* @extends {BuildersButton}
*/
class ButtonBuilder extends BuildersButton {
constructor({ emoji, ...data } = {}) {
super(toSnakeCase({ ...data, emoji: emoji && typeof emoji === 'string' ? parseEmoji(emoji) : emoji }));
super(toSnakeCase({ ...data, emoji: emoji && typeof emoji === 'string' ? resolvePartialEmoji(emoji) : emoji }));
}

/**
Expand All @@ -20,7 +20,7 @@ class ButtonBuilder extends BuildersButton {
*/
setEmoji(emoji) {
if (typeof emoji === 'string') {
return super.setEmoji(parseEmoji(emoji));
return super.setEmoji(resolvePartialEmoji(emoji));
}
return super.setEmoji(emoji);
}
Expand Down
6 changes: 3 additions & 3 deletions packages/discord.js/src/structures/SelectMenuBuilder.js
Expand Up @@ -2,7 +2,7 @@

const { SelectMenuBuilder: BuildersSelectMenu, isJSONEncodable, normalizeArray } = require('@discordjs/builders');
const { toSnakeCase } = require('../util/Transformers');
const { parseEmoji } = require('../util/Util');
const { resolvePartialEmoji } = require('../util/Util');

/**
* Class used to build select menu components to be sent through the API
Expand All @@ -15,7 +15,7 @@ class SelectMenuBuilder extends BuildersSelectMenu {
...data,
options: options?.map(({ emoji, ...option }) => ({
...option,
emoji: emoji && typeof emoji === 'string' ? parseEmoji(emoji) : emoji,
emoji: emoji && typeof emoji === 'string' ? resolvePartialEmoji(emoji) : emoji,
})),
}),
);
Expand All @@ -35,7 +35,7 @@ class SelectMenuBuilder extends BuildersSelectMenu {
const { emoji, ...option } = selectMenuOption;
return {
...option,
emoji: typeof emoji === 'string' ? parseEmoji(emoji) : emoji,
emoji: typeof emoji === 'string' ? resolvePartialEmoji(emoji) : emoji,
};
}

Expand Down
6 changes: 3 additions & 3 deletions packages/discord.js/src/structures/SelectMenuOptionBuilder.js
Expand Up @@ -2,7 +2,7 @@

const { SelectMenuOptionBuilder: BuildersSelectMenuOption, isJSONEncodable } = require('@discordjs/builders');
const { toSnakeCase } = require('../util/Transformers');
const { parseEmoji } = require('../util/Util');
const { resolvePartialEmoji } = require('../util/Util');

/**
* Represents a select menu option builder.
Expand All @@ -13,7 +13,7 @@ class SelectMenuOptionBuilder extends BuildersSelectMenuOption {
super(
toSnakeCase({
...data,
emoji: emoji && typeof emoji === 'string' ? parseEmoji(emoji) : emoji,
emoji: emoji && typeof emoji === 'string' ? resolvePartialEmoji(emoji) : emoji,
}),
);
}
Expand All @@ -24,7 +24,7 @@ class SelectMenuOptionBuilder extends BuildersSelectMenuOption {
*/
setEmoji(emoji) {
if (typeof emoji === 'string') {
return super.setEmoji(parseEmoji(emoji));
return super.setEmoji(resolvePartialEmoji(emoji));
}
return super.setEmoji(emoji);
}
Expand Down

0 comments on commit 660e212

Please sign in to comment.