fix: return only boolean for disabled (#8965)

* fix: return only boolean for `disabled` * fix: return only boolean for `disabled` Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
discordjs · Dec 24, 2022 · 6614603 · 6614603
1 parent 153352a
commit 6614603
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/discord.js/src/structures/BaseSelectMenuComponent.js b/packages/discord.js/src/structures/BaseSelectMenuComponent.js
@@ -45,11 +45,11 @@ class BaseSelectMenuComponent extends Component {
 
   /**
    * Whether this select menu is disabled
-   * @type {?boolean}
+   * @type {boolean}
    * @readonly
    */
   get disabled() {
-    return this.data.disabled ?? null;
+    return this.data.disabled ?? false;
   }
 }
 

diff --git a/packages/discord.js/src/structures/ButtonComponent.js b/packages/discord.js/src/structures/ButtonComponent.js
@@ -36,11 +36,11 @@ class ButtonComponent extends Component {
 
   /**
    * Whether this button is disabled
-   * @type {?boolean}
+   * @type {boolean}
    * @readonly
    */
   get disabled() {
-    return this.data.disabled ?? null;
+    return this.data.disabled ?? false;
   }
 
   /**

diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts
@@ -678,7 +678,7 @@ export class ButtonComponent extends Component<APIButtonComponent> {
   public get style(): ButtonStyle;
   public get label(): string | null;
   public get emoji(): APIMessageComponentEmoji | null;
-  public get disabled(): boolean | null;
+  public get disabled(): boolean;
   public get customId(): string | null;
   public get url(): string | null;
 }
@@ -759,7 +759,7 @@ export class BaseSelectMenuComponent<Data extends APISelectMenuComponent> extend
   public get maxValues(): number | null;
   public get minValues(): number | null;
   public get customId(): string;
-  public get disabled(): boolean | null;
+  public get disabled(): boolean;
 }
 
 export class StringSelectMenuComponent extends BaseSelectMenuComponent<APIStringSelectComponent> {