fix(StickerPack): Nullify bannerId (#7119)

discordjs · Dec 21, 2021 · 6bb03f2 · 6bb03f2
1 parent 645b3f8
commit 6bb03f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/structures/StickerPack.js b/src/structures/StickerPack.js
@@ -50,9 +50,9 @@ class StickerPack extends Base {
 
     /**
      * The id of the sticker pack's banner image
-     * @type {Snowflake}
+     * @type {?Snowflake}
      */
-    this.bannerId = pack.banner_asset_id;
+    this.bannerId = pack.banner_asset_id ?? null;
   }
 
   /**
@@ -85,10 +85,10 @@ class StickerPack extends Base {
   /**
    * The URL to this sticker pack's banner.
    * @param {StaticImageURLOptions} [options={}] Options for the Image URL
-   * @returns {string}
+   * @returns {?string}
    */
   bannerURL({ format, size } = {}) {
-    return this.client.rest.cdn.StickerPackBanner(this.bannerId, format, size);
+    return this.bannerId && this.client.rest.cdn.StickerPackBanner(this.bannerId, format, size);
   }
 }
 

diff --git a/typings/index.d.ts b/typings/index.d.ts
@@ -2102,15 +2102,15 @@ export class StickerPack extends Base {
   private constructor(client: Client, data: RawStickerPackData);
   public readonly createdTimestamp: number;
   public readonly createdAt: Date;
-  public bannerId: Snowflake;
+  public bannerId: Snowflake | null;
   public readonly coverSticker: Sticker | null;
   public coverStickerId: Snowflake | null;
   public description: string;
   public id: Snowflake;
   public name: string;
   public skuId: Snowflake;
   public stickers: Collection<Snowflake, Sticker>;
-  public bannerURL(options?: StaticImageURLOptions): string;
+  public bannerURL(options?: StaticImageURLOptions): string | null;
 }
 
 /** @deprecated See [Self-serve Game Selling Deprecation](https://support-dev.discord.com/hc/en-us/articles/4414590563479) for more information */