fix(APIMessage): don't send embeds for non-webhook requests

discordjs · May 29, 2021 · 6c66226 · 6c66226
1 parent 6339ac1
commit 6c66226
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/structures/APIMessage.js b/src/structures/APIMessage.js
@@ -125,6 +125,7 @@ class APIMessage {
    */
   resolveData() {
     if (this.data) return this;
+    const thisIsWebhook = this.isWebhook;
 
     const content = this.makeContent();
     const tts = Boolean(this.options.tts);
@@ -139,7 +140,7 @@ class APIMessage {
     }
 
     const embedLikes = [];
-    if (this.isInteraction || this.isWebhook) {
+    if (this.isInteraction || thisIsWebhook) {
       if (this.options.embeds) {
         embedLikes.push(...this.options.embeds);
       }
@@ -150,7 +151,7 @@ class APIMessage {
 
     let username;
     let avatarURL;
-    if (this.isWebhook) {
+    if (thisIsWebhook) {
       username = this.options.username || this.target.name;
       if (this.options.avatarURL) avatarURL = this.options.avatarURL;
     }
@@ -192,7 +193,7 @@ class APIMessage {
       tts,
       nonce,
       embed: this.options.embed === null ? null : embeds[0],
-      embeds,
+      embeds: thisIsWebhook ? embeds : undefined,
       username,
       avatar_url: avatarURL,
       allowed_mentions: