fix(CachedManager): return updated data when cache is false (#6685)

discordjs · Sep 27, 2021 · 8426770 · 8426770
1 parent 79b1b20
commit 8426770
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/managers/CachedManager.js b/src/managers/CachedManager.js
@@ -45,8 +45,15 @@ class CachedManager extends DataManager {
 
   _add(data, cache = true, { id, extras = [] } = {}) {
     const existing = this.cache.get(id ?? data.id);
-    if (cache) existing?._patch(data);
-    if (existing) return existing;
+    if (existing) {
+      if (cache) {
+        existing._patch(data);
+        return existing;
+      }
+      const clone = existing._clone();
+      clone._patch(data);
+      return clone;
+    }
 
     const entry = this.holds ? new this.holds(this.client, data, ...extras) : data;
     if (cache) this.cache.set(id ?? entry.id, entry);