feat(UserManager): allow #fetch to take UserResolvable (#6677)

discordjs · Sep 26, 2021 · a06a87a · a06a87a
1 parent 1ca8d2c
commit a06a87a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/managers/UserManager.js b/src/managers/UserManager.js
@@ -56,11 +56,12 @@ class UserManager extends CachedManager {
 
   /**
    * Obtains a user from Discord, or the user cache if it's already available.
-   * @param {Snowflake} id The user's id
+   * @param {UserResolvable} user The user to fetch
    * @param {BaseFetchOptions} [options] Additional options for this fetch
    * @returns {Promise<User>}
    */
-  async fetch(id, { cache = true, force = false } = {}) {
+  async fetch(user, { cache = true, force = false } = {}) {
+    const id = this.resolveId(user);
     if (!force) {
       const existing = this.cache.get(id);
       if (existing && !existing.partial) return existing;

diff --git a/typings/index.d.ts b/typings/index.d.ts
@@ -2770,7 +2770,7 @@ export class ThreadMemberManager extends CachedManager<Snowflake, ThreadMember,
 
 export class UserManager extends CachedManager<Snowflake, User, UserResolvable> {
   public constructor(client: Client, iterable?: Iterable<RawUserData>);
-  public fetch(id: Snowflake, options?: BaseFetchOptions): Promise<User>;
+  public fetch(user: UserResolvable, options?: BaseFetchOptions): Promise<User>;
 }
 
 export class VoiceStateManager extends CachedManager<Snowflake, VoiceState, typeof VoiceState> {