refactor: make requested changes

discordjs · Mar 12, 2022 · a3ebe36 · a3ebe36
1 parent 48fdac6
commit a3ebe36
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 32 deletions.
diff --git a/packages/builders/src/components/Components.ts b/packages/builders/src/components/Components.ts
@@ -1,7 +1,6 @@
 import { APIMessageComponent, APIModalComponent, ComponentType } from 'discord-api-types/v9';
 import { ActionRowBuilder, ButtonBuilder, ComponentBuilder, SelectMenuBuilder, TextInputBuilder } from '../index';
 import type { MessageComponentBuilder, ModalComponentBuilder } from './ActionRow';
-import { UnknownComponentBuilder } from './UnknownComponent';
 
 export interface MappedComponentTypes {
 	[ComponentType.ActionRow]: ActionRowBuilder;
@@ -37,7 +36,6 @@ export function createComponentBuilder(
 		default:
 			// @ts-expect-error
 			// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
-			console.warn(`Cannot properly serialize component type: ${data.type}`);
-			return new UnknownComponentBuilder(data);
+			throw new Error(`Cannot properly serialize component type: ${data.type}`);
 	}
 }
diff --git a/packages/builders/src/components/UnknownComponent.ts b/packages/builders/src/components/UnknownComponent.ts
diff --git a/packages/discord.js/src/structures/Component.js b/packages/discord.js/src/structures/Component.js
@@ -13,10 +13,10 @@ class Component {
    */
   constructor(data) {
     /**
-     * The API data associated with this button component
+     * The API data associated with this component
      * @type {APIMessageComponent}
      */
-    this.data = { ...data };
+    this.data = data;
   }
 
   /**

diff --git a/packages/discord.js/src/util/Components.js b/packages/discord.js/src/util/Components.js
@@ -76,10 +76,7 @@ class Components extends null {
       case ComponentType.SelectMenu:
         return new SelectMenuComponent(data);
       default:
-        // This is done for future-proofing purposes to prevent
-        // crashes when unknown component types are found.
-        console.warn(`Found unknown component type: ${data.type}`);
-        return new Component(data);
+        throw new Error(`Found unknown component type: ${data.type}`);
     }
   }
 }