Skip to content

Commit

Permalink
refactor(RequestHandler): use x-ratelimit-reset-after when present (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
ckohen committed Apr 30, 2021
1 parent cdcc50f commit a5d41c9
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions src/rest/RequestHandler.js
Expand Up @@ -17,7 +17,11 @@ function getAPIOffset(serverDate) {
return new Date(serverDate).getTime() - Date.now();
}

function calculateReset(reset, serverDate) {
function calculateReset(reset, resetAfter, serverDate) {
// Use direct reset time when available, server date becomes irrelevant in this case
if (resetAfter) {
return Date.now() + Number(resetAfter) * 1000;
}
return new Date(Number(reset) * 1000).getTime() - getAPIOffset(serverDate);
}

Expand Down Expand Up @@ -152,12 +156,14 @@ class RequestHandler {
const limit = res.headers.get('x-ratelimit-limit');
const remaining = res.headers.get('x-ratelimit-remaining');
const reset = res.headers.get('x-ratelimit-reset');
const resetAfter = res.headers.get('x-ratelimit-reset-after');
this.limit = limit ? Number(limit) : Infinity;
this.remaining = remaining ? Number(remaining) : 1;
this.reset = reset ? calculateReset(reset, serverDate) : Date.now();

this.reset = reset || resetAfter ? calculateReset(reset, resetAfter, serverDate) : Date.now();

// https://github.com/discordapp/discord-api-docs/issues/182
if (request.route.includes('reactions')) {
if (!resetAfter && request.route.includes('reactions')) {
this.reset = new Date(serverDate).getTime() - getAPIOffset(serverDate) + 250;
}

Expand Down

0 comments on commit a5d41c9

Please sign in to comment.