Skip to content

Commit

Permalink
feat(Client): add InviteGenerationOptions#additionalScopes (#5215)
Browse files Browse the repository at this point in the history
Co-authored-by: izexi <43889168+izexi@users.noreply.github.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
  • Loading branch information
3 people committed Feb 10, 2021
1 parent 56d8b44 commit ae3c3d8
Show file tree
Hide file tree
Showing 4 changed files with 60 additions and 1 deletion.
15 changes: 14 additions & 1 deletion src/client/Client.js
Expand Up @@ -17,7 +17,7 @@ const Invite = require('../structures/Invite');
const VoiceRegion = require('../structures/VoiceRegion');
const Webhook = require('../structures/Webhook');
const Collection = require('../util/Collection');
const { Events, DefaultOptions } = require('../util/Constants');
const { Events, DefaultOptions, InviteScopes } = require('../util/Constants');
const DataResolver = require('../util/DataResolver');
const Intents = require('../util/Intents');
const Permissions = require('../util/Permissions');
Expand Down Expand Up @@ -377,6 +377,7 @@ class Client extends BaseClient {
* @property {PermissionResolvable} [permissions] Permissions to request
* @property {GuildResolvable} [guild] Guild to preselect
* @property {boolean} [disableGuildSelect] Whether to disable the guild selection
* @property {InviteScope[]} [additionalScopes] Whether any additional scopes should be requested
*/

/**
Expand Down Expand Up @@ -418,6 +419,18 @@ class Client extends BaseClient {
query.set('guild_id', guildID);
}

if (options.additionalScopes) {
const scopes = options.additionalScopes;
if (!Array.isArray(scopes)) {
throw new TypeError('INVALID_TYPE', 'additionalScopes', 'Array of Invite Scopes', true);
}
const invalidScope = scopes.find(scope => !InviteScopes.includes(scope));
if (invalidScope) {
throw new TypeError('INVALID_ELEMENT', 'Array', 'additionalScopes', invalidScope);
}
query.set('scope', ['bot', ...scopes].join(' '));
}

return `${this.options.http.api}${this.api.oauth2.authorize}?${query}`;
}

Expand Down
1 change: 1 addition & 0 deletions src/errors/Messages.js
Expand Up @@ -89,6 +89,7 @@ const Messages = {
GUILD_UNCACHED_ME: 'The client user as a member of this guild is uncached.',

INVALID_TYPE: (name, expected, an = false) => `Supplied ${name} is not a${an ? 'n' : ''} ${expected}.`,
INVALID_ELEMENT: (type, name, elem) => `Supplied ${type} ${name} includes an invalid element: ${elem}`,

WEBHOOK_MESSAGE: 'The message was not sent by a webhook.',

Expand Down
30 changes: 30 additions & 0 deletions src/util/Constants.js
Expand Up @@ -375,6 +375,36 @@ exports.WSEvents = keyMirror([
'WEBHOOKS_UPDATE',
]);

/**
* A valid scope to request when generating an invite link.
* <warn>Scopes that require whitelist are not considered valid for this generator</warn>
* * `applications.builds.read`: allows reading build data for a users applications
* * `applications.commands`: allows this bot to create commands in the server
* * `applications.entitlements`: allows reading entitlements for a users applications
* * `applications.store.update`: allows reading and updating of store data for a users applications
* * `connections`: makes the endpoint for getting a users connections available
* * `email`: allows the `/users/@me` endpoint return with an email
* * `identify`: allows the `/users/@me` endpoint without an email
* * `guilds`: makes the `/users/@me/guilds` endpoint available for a user
* * `guilds.join`: allows the bot to join the user to any guild it is in using Guild#addMember
* * `gdm.join`: allows joining the user to a group dm
* * `webhook.incoming`: generates a webhook to a channel
* @typedef {string} InviteScope
*/
exports.InviteScopes = [
'applications.builds.read',
'applications.commands',
'applications.entitlements',
'applications.store.update',
'connections',
'email',
'identity',
'guilds',
'guilds.join',
'gdm.join',
'webhook.incoming',
];

/**
* The type of a message, e.g. `DEFAULT`. Here are the available types:
* * DEFAULT
Expand Down
15 changes: 15 additions & 0 deletions typings/index.d.ts
Expand Up @@ -513,6 +513,7 @@ declare module 'discord.js' {
SMALL: 1;
BIG: 2;
};
InviteScopes: InviteScope[];
MessageTypes: MessageType[];
SystemMessageTypes: SystemMessageType[];
ActivityTypes: ActivityType[];
Expand Down Expand Up @@ -2824,6 +2825,7 @@ declare module 'discord.js' {
permissions?: PermissionResolvable;
guild?: GuildResolvable;
disableGuildSelect?: boolean;
additionalScopes?: InviteScope[];
}

interface InviteOptions {
Expand All @@ -2836,6 +2838,19 @@ declare module 'discord.js' {

type InviteResolvable = string;

type InviteScope =
| 'applications.builds.read'
| 'applications.commands'
| 'applications.entitlements'
| 'applications.store.update'
| 'connections'
| 'email'
| 'identity'
| 'guilds'
| 'guilds.join'
| 'gdm.join'
| 'webhook.incoming';

type GuildTemplateResolvable = string;

type MembershipStates = 'INVITED' | 'ACCEPTED';
Expand Down

0 comments on commit ae3c3d8

Please sign in to comment.