refactor: make data public in builders (#7486)

discordjs · Feb 20, 2022 · ba31203 · ba31203
1 parent 8dbd345
commit ba31203
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/packages/builders/src/components/ActionRow.ts b/packages/builders/src/components/ActionRow.ts
@@ -15,6 +15,9 @@ export type ActionRowComponent = ButtonComponent | SelectMenuComponent;
 export class ActionRow<T extends ActionRowComponent = ActionRowComponent> extends Component<
 	Omit<Partial<APIActionRowComponent<APIMessageComponent>> & { type: ComponentType.ActionRow }, 'components'>
 > {
+	/**
+	 * The components within this action row
+	 */
 	public readonly components: T[];
 
 	public constructor({ components, ...data }: Partial<APIActionRowComponent<APIMessageComponent>> = {}) {

diff --git a/packages/builders/src/components/Component.ts b/packages/builders/src/components/Component.ts
@@ -19,7 +19,7 @@ export abstract class Component<
 	/**
 	 * The API data associated with this component
 	 */
-	protected readonly data: DataType;
+	public readonly data: DataType;
 
 	public abstract toJSON(): APIMessageComponent;
 

diff --git a/packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts b/packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts
@@ -9,6 +9,9 @@ import isEqual from 'fast-deep-equal';
 export class UnsafeSelectMenuComponent extends Component<
 	Partial<Omit<APISelectMenuComponent, 'options'>> & { type: ComponentType.SelectMenu }
 > {
+	/**
+	 * The options within this select menu
+	 */
 	public readonly options: UnsafeSelectMenuOption[];
 
 	public constructor(data?: Partial<APISelectMenuComponent>) {

diff --git a/packages/builders/src/messages/embed/UnsafeEmbed.ts b/packages/builders/src/messages/embed/UnsafeEmbed.ts
@@ -41,7 +41,7 @@ export interface EmbedImageData extends Omit<APIEmbedImage, 'proxy_url'> {
  * Represents a non-validated embed in a message (image/video preview, rich embed, etc.)
  */
 export class UnsafeEmbed implements Equatable<APIEmbed | UnsafeEmbed> {
-	protected data: APIEmbed;
+	public readonly data: APIEmbed;
 
 	public constructor(data: APIEmbed = {}) {
 		this.data = { ...data };