refactor(BitField): reverse iterator/toArray responsibilities (#9118)

refactor(BitField): reverse iterator/toArray responsabilities
discordjs · Feb 17, 2023 · f70df91 · f70df91 · vercel · Feb 17, 2023
1 parent b8684e0
commit f70df91
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/discord.js/src/util/BitField.js b/packages/discord.js/src/util/BitField.js
@@ -127,7 +127,7 @@ class BitField {
    * @returns {string[]}
    */
   toArray(...hasParams) {
-    return Object.keys(this.constructor.Flags).filter(bit => this.has(bit, ...hasParams));
+    return [...this[Symbol.iterator](...hasParams)];
   }
 
   toJSON() {
@@ -138,8 +138,10 @@ class BitField {
     return this.bitfield;
   }
 
-  *[Symbol.iterator]() {
-    yield* this.toArray();
+  *[Symbol.iterator](...hasParams) {
+    for (const bitName of Object.keys(this.constructor.Flags)) {
+      if (this.has(bitName, ...hasParams)) yield bitName;
+    }
   }
 
   /**