Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildAuditLogs): make #target a channel for channel related logs #5781

Merged
merged 3 commits into from Jun 10, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Jun 8, 2021

Please describe the changes this PR makes and why it should be merged:

Currently, for logs related to CHANNEL_* events, GuildAuditLogsEntry#target is an object containing only the id of the related channel. This PR turns this target prop into a channel using the data in the changes object. There are also some documentation related changes.

Status and versioning classification:

  • Code changes have been tested against the Discord API

@iCrawl iCrawl requested a review from SpaceEEC June 9, 2021 12:17
src/structures/GuildAuditLogs.js Outdated Show resolved Hide resolved
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
@iCrawl iCrawl merged commit eb0291d into discordjs:master Jun 10, 2021
@iShibi iShibi deleted the feat-logs branch June 15, 2021 15:00
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants