Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildAuditLogs): make #target a channel for channel related logs #5781

Merged
merged 3 commits into from Jun 10, 2021
Merged

feat(GuildAuditLogs): make #target a channel for channel related logs #5781

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30b87bc
feat(GuildAuditLogs): make #target a channel for channel related logs
iShibi Jun 8, 2021
284315a
refactor(GuildAuditLogs): do not create a new channel
iShibi Jun 8, 2021
9446ef9
docs(GuildAuditLogs): remove channel type from jsdoc of #extra
iShibi Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/structures/GuildAuditLogs.js
View file
Open in desktop
Expand Up @@ -79,7 +79,7 @@ const Targets = {
* * INTEGRATION_CREATE: 80
* * INTEGRATION_UPDATE: 81
* * INTEGRATION_DELETE: 82
* @typedef {?number|string} AuditLogAction
* @typedef {?(number|string)} AuditLogAction
*/

/**
Expand Down Expand Up @@ -179,15 +179,17 @@ class GuildAuditLogs {
/**
* The target of an entry. It can be one of:
* * A guild
* * A channel
* * A user
* * A role
* * An emoji
* * An invite
* * A webhook
* * An emoji
* * A message
* * An integration
* * An object with an id key if target was deleted
* * An object where the keys represent either the new value or the old value
* @typedef {?Object|Guild|User|Role|GuildEmoji|Invite|Webhook|Integration} AuditLogEntryTarget
* @typedef {?(Object|Guild|Channel|User|Role|Invite|Webhook|GuildEmoji|Message|Integration)} AuditLogEntryTarget
*/

/**
Expand Down Expand Up @@ -349,7 +351,7 @@ class GuildAuditLogsEntry {

/**
* Any extra data from the entry
* @type {?Object|Role|GuildMember}
* @type {?(Object|Role|GuildMember)}
*/
this.extra = null;
switch (data.action_type) {
Expand Down Expand Up @@ -480,8 +482,18 @@ class GuildAuditLogsEntry {
),
guild,
);
} else if (targetType === Targets.CHANNEL) {
this.target =
guild.channels.cache.get(data.target_id) ||
this.changes.reduce(
(o, c) => {
o[c.key] = c.new || c.old;
return o;
},
{ id: data.target_id },
);
} else if (data.target_id) {
this.target = guild[`${targetType.toLowerCase()}s`].cache.get(data.target_id) || { id: data.target_id };
this.target = guild[`${targetType.toLowerCase()}s`]?.cache.get(data.target_id) || { id: data.target_id };
}
}

Expand Down