feat(Managers): new ApplicationCommandPermissionsManager #5897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckohen
force-pushed
the
appcommand-perm-manager
branch
from
180edea
to
911624e
Compare
SpaceEEC
previously requested changes
Jun 21, 2021
jzeuzs
suggested changes
Jun 22, 2021
iCrawl
approved these changes
Jun 23, 2021
kyranet
previously requested changes
Jun 23, 2021
vladfrangu
previously requested changes
Jun 23, 2021
|
This needs a rebase. |
ckohen
force-pushed
the
appcommand-perm-manager
branch
from
79f2c9b
to
a8f39cc
Compare
kyranet
approved these changes
Jun 24, 2021
ckohen
force-pushed
the
appcommand-perm-manager
branch
from
a8f39cc
to
99292d9
Compare
vladfrangu
previously requested changes
Jun 24, 2021
jzeuzs
approved these changes
Jun 24, 2021
ckohen
force-pushed
the
appcommand-perm-manager
branch
from
99292d9
to
4de68f7
Compare
|
This needs a rebase. |
ckohen
force-pushed
the
appcommand-perm-manager
branch
from
4de68f7
to
633169a
Compare
vladfrangu
previously requested changes
Jun 25, 2021
ckohen
force-pushed
the
appcommand-perm-manager
branch
from
633169a
to
3fd430d
Compare
SpaceEEC
previously requested changes
Jun 26, 2021
Co-Authored-By: SpaceEEC <24881032+SpaceEEC@users.noreply.github.com>
Co-authored-by: Yoshida Tomio <mail@tomio.codes>
Co-authored-by: Antonio Rom谩n <kyradiscord@gmail.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
ckohen
force-pushed
the
appcommand-perm-manager
branch
from
3fd430d
to
ba99a15
Compare
vladfrangu
requested changes
Jun 27, 2021
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
|
Sorry about the commit msg on the last commit, did it from mobile. If we hit another rebase I'll fix it |
vladfrangu
approved these changes
Jun 28, 2021
SpaceEEC
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Replaces and closes #5695 as the PR seems to be abandoned. This takes a good chunk of the code from that PR, but moves existing code and new code into a new manager while addressing requested changes.
Benefits of this approach:
Each command has its own way to access all of its permissions properties alongside the guild and global versions
Every function takes an object, making the somewhat confusing required vs optional parameters a little easier to understand.
Typescript users hopefully know exactly what they need to use the manager due to some hefty overloads and type passing.
(I did a lot of things that I don't know whether will work or not, but they should 馃...I hope )
Status and versioning classification: