New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interactions and slash commands #638
feat: interactions and slash commands #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Header links should use sentence case
- 4 space indents are being used in codeblocks instead of tabs
- Line highlighting can be used across this page to show which lines of the codeblocks have changed
- Numbers should be written as words (e.g., 3 -> "three")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor fixes
All wanted changes should hopefully be addressed now, lmk if anything else seems off :) |
LGTM! 🎉 I'll notify you once I have the Discord interactions components working so that you can update the message components used here, After that, I'll do another review. Feel free to add anything else you feel is necessary between now and then. Thanks for the PR. 😄 |
Thank you 😄 unless Jan thinks that some other use-scenario of his PR needs to be explained, this is done, except for the message components you mentioned. Thanks for the quick review process, cheers. |
It would be nice if there are images showing the progress gradually on both pages. I'd suggest using normal images for now and hopefully, we'll get it in-built into the Otherwise, every thing looks great to me |
Images aren't necessary as Sanc has an update in the works for vue-discord-message that will incooperate interaction components, this PR will not be merged until the next major release anyway so there is no need to rush it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more minor things:
Class.method()
should be replaced withClass#method()
as the dot means that it's a static method- The command data objects should be renamed from
commanddata
tocommandData
(or justdata
) - You're missing trailing commas
requested changes acknowledged, ready for re-review, imo only missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly other word choice options or sentence structure changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some fixes regarding punctuation, commas, etc...
(I'm not sure if it's showing the suggested changes or not for this... Let me know if it is or not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these would help. But in my view, these would be the proper places to put punctuations. However, I also make mistakes in grammar, so if any are made, it would be fine if it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits and suggestions, should be ready to merge after
Applied all suggestions 👍🏼 |
Co-authored-by: Justin <justinleeong@gmail.com>
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com> Co-authored-by: Sanctuary <Danktuary@users.noreply.github.com>
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar, sentence rephrasing, and codeblock content shortening
Co-authored-by: Sanctuary <Danktuary@users.noreply.github.com>
…adrifcastr/guide into feat-interactions-slashcommands
Please describe the changes this PR makes and why it should be merged:
This PR adds an Interactions category to the side bar and adds a guide on how to reply to slash commands based on discordjs/discord.js#5448 .
I expect this to be held off for until the aforementioned PR is merged and the next major version of the lib is released.
I have paid utmost attention at everything outlined in
CONTRIBUTING.md
, and made sure to avoid grammatical and other errors, however as this is my first contribution I expect that some things will need to be adjusted/fixed/rewritten to fully satisfy the requirements, and I am happy to do so as the reviews come in.