Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interactions and slash commands #638

Merged
merged 105 commits into from Jul 6, 2021
Merged

feat: interactions and slash commands #638

merged 105 commits into from Jul 6, 2021

Conversation

castdrian
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR adds an Interactions category to the side bar and adds a guide on how to reply to slash commands based on discordjs/discord.js#5448 .

I expect this to be held off for until the aforementioned PR is merged and the next major version of the lib is released.

I have paid utmost attention at everything outlined in CONTRIBUTING.md, and made sure to avoid grammatical and other errors, however as this is my first contribution I expect that some things will need to be adjusted/fixed/rewritten to fully satisfy the requirements, and I am happy to do so as the reviews come in.

@Danktuary Danktuary added the t: page/section addition Pull Request to add new content to the guide label Apr 10, 2021
Copy link
Member

@Danktuary Danktuary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Header links should use sentence case
  • 4 space indents are being used in codeblocks instead of tabs
  • Line highlighting can be used across this page to show which lines of the codeblocks have changed
  • Numbers should be written as words (e.g., 3 -> "three")

guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
Copy link
Contributor

@iShibi iShibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor fixes

@castdrian
Copy link
Contributor Author

  • Header links should use sentence case
  • 4 space indents are being used in codeblocks instead of tabs
  • Line highlighting can be used across this page to show which lines of the codeblocks have changed
  • Numbers should be written as words (e.g., 3 -> "three")

All wanted changes should hopefully be addressed now, lmk if anything else seems off :)

@Danktuary
Copy link
Member

LGTM! 🎉 I'll notify you once I have the Discord interactions components working so that you can update the message components used here, After that, I'll do another review. Feel free to add anything else you feel is necessary between now and then. Thanks for the PR. 😄

@castdrian
Copy link
Contributor Author

Thank you 😄 unless Jan thinks that some other use-scenario of his PR needs to be explained, this is done, except for the message components you mentioned. Thanks for the quick review process, cheers.

@WiseDevHelper
Copy link
Contributor

WiseDevHelper commented Apr 23, 2021

It would be nice if there are images showing the progress gradually on both pages. I'd suggest using normal images for now and hopefully, we'll get it in-built into the vue-discord-message component later.

Otherwise, every thing looks great to me

@castdrian
Copy link
Contributor Author

It would be nice if there are images showing the progress gradually on both pages. I'd suggest using normal images for now and hopefully, we'll get it in-built into the vue-discord-message component later.

Otherwise, every thing looks great to me

Images aren't necessary as Sanc has an update in the works for vue-discord-message that will incooperate interaction components, this PR will not be merged until the next major release anyway so there is no need to rush it

Copy link
Contributor

@vaporoxx vaporoxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more minor things:

  • Class.method() should be replaced with Class#method() as the dot means that it's a static method
  • The command data objects should be renamed from commanddata to commandData (or just data)
  • You're missing trailing commas

guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
@castdrian
Copy link
Contributor Author

requested changes acknowledged, ready for re-review, imo only missing vue-discord-message interaction components now :D

Copy link
Contributor

@Darqam Darqam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly other word choice options or sentence structure changes.

guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
@castdrian castdrian changed the title feat: interactions and replying to slash commands feat: interactions and slash commands May 8, 2021
Copy link

@Muh9049 Muh9049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some fixes regarding punctuation, commas, etc...
(I'm not sure if it's showing the suggested changes or not for this... Let me know if it is or not)

Copy link
Contributor

@J-Human J-Human left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these would help. But in my view, these would be the proper places to put punctuations. However, I also make mistakes in grammar, so if any are made, it would be fine if it's not needed.

guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vaporoxx vaporoxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/replying-to-slash-commands.md Outdated Show resolved Hide resolved
@almostSouji almostSouji changed the base branch from master to v13-prep June 28, 2021 00:02
Copy link
Member

@almostSouji almostSouji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits and suggestions, should be ready to merge after

guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/slash-command-permissions.md Outdated Show resolved Hide resolved
@castdrian
Copy link
Contributor Author

some nits and suggestions, should be ready to merge after

Applied all suggestions 👍🏼

castdrian and others added 22 commits July 5, 2021 20:01
Co-authored-by: Justin <justinleeong@gmail.com>
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
Co-authored-by: Jan <66554238+vaporox@users.noreply.github.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Souji <timoqueezle@gmail.com>
Co-authored-by: Sanctuary <Danktuary@users.noreply.github.com>
@castdrian
Copy link
Contributor Author

rebased

Copy link
Member

@Danktuary Danktuary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar, sentence rephrasing, and codeblock content shortening

guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/registering-slash-commands.md Outdated Show resolved Hide resolved
guide/interactions/slash-command-permissions.md Outdated Show resolved Hide resolved
guide/interactions/slash-command-permissions.md Outdated Show resolved Hide resolved
guide/interactions/slash-command-permissions.md Outdated Show resolved Hide resolved
guide/interactions/slash-command-permissions.md Outdated Show resolved Hide resolved
guide/interactions/slash-command-permissions.md Outdated Show resolved Hide resolved
castdrian and others added 3 commits July 6, 2021 12:25
@Danktuary Danktuary merged commit 1011b31 into discordjs:v13-prep Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: page/section addition Pull Request to add new content to the guide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet