feat(Rest): expose https.Agent options #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
previously requested changes
Jul 23, 2021
|
This PR has requested changes from 20 days ago, please resolve them at your earliest convenience @shinotheshino |
kyranet
previously requested changes
Aug 14, 2021
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
SpaceEEC
approved these changes
Aug 14, 2021
kyranet
approved these changes
Aug 15, 2021
iCrawl
approved these changes
Aug 17, 2021
ckohen
added a commit
to ckohen/discord.js-modules
that referenced
this pull request
Nov 14, 2021
Ported from discordjs/discord.js#6177 Co-authored-by: Shino <shinotheshino@gmail.com> Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This exposes the
https.Agentoptions object forAPIRequestas a client option (HTTPOptions#agent?: https.AgentOptions). I am currently working on mock integration testing for discord.js applications, involving a mock REST API and gateway, but to work with a local server and x509 certificates, it is necessary to change some agent options (rejectUnauthorized: false).Status and versioning classification: