feat: add support for GuildScheduledEvent #6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
reviewed
Aug 21, 2021
ImRodry
reviewed
Aug 21, 2021
NotSugden
reviewed
Aug 23, 2021
Jiralite
reviewed
Aug 29, 2021
ImRodry
suggested changes
Sep 28, 2021
There was a problem hiding this comment.
Some things I noticed after going through this PR again
I also think you should change Invite#INVITES_PATTERN to /discord(?:(?:app)?\.com\/invite|\.gg(?:\/invite)?)\/([\w-]{2,255})$/gi (added the $ at the end to match the end of the string) and add a new property under GuildEvent called EVENTS_PATTERN with the following regex: /discord(?:(?:app)?\.com\/invite|\.gg(?:\/invite)?)\/[\w-]{2,255}\?event=([0-9]{17,19})/gi
iShibi
force-pushed
the
feat-guild-event
branch
from
0619667
to
ccc1a17
Compare
This was referenced Nov 17, 2021
Closed
iShibi
changed the title
|
This is ready for review |
ImRodry
reviewed
Nov 17, 2021
Jiralite
requested changes
Nov 17, 2021
Jiralite
reviewed
Nov 17, 2021
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
iShibi
force-pushed
the
feat-guild-event
branch
from
e38bd83
to
b5cfe27
Compare
vladfrangu
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds support for
GuildScheduledEvent:Todo:
GuildScheduledEventclassGuildScheduledEventclassGetList of guild events in a guildPostCreate a guild eventGetA guild event by idDeleteDelete a guild eventPatchModify a guild eventGuildEventManagerMANAGE_EVENTSpermissionGuildScheduledEventrelated audit logsStatus and versioning classification: