Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UserManager): allow #fetch to take UserResolvable #6677

Merged
merged 2 commits into from Sep 26, 2021
Merged

feat(UserManager): allow #fetch to take UserResolvable #6677

merged 2 commits into from Sep 26, 2021

Conversation

iShibi
Copy link
Contributor

@iShibi iShibi commented Sep 22, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:

Allow UserManager#fetch to take a UserResolvable

Status and versioning classification:

  • I know how to update typings and have done so
  • Code changes have been tested against the Discord API
  • This PR includes breaking changes ⚠️

@iCrawl iCrawl added this to the Version 14 milestone Sep 23, 2021
vladfrangu
vladfrangu approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niche but understandable

SpaceEEC
SpaceEEC approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what's breaking here, but anyway. 😁

@iShibi
Copy link
Contributor Author

iShibi commented Sep 24, 2021

yeah, I guess it isn't. I thought changing the parameter name from id to user was breaking. Anyway:

breakingnt

@iCrawl iCrawl modified the milestones: Version 14, Version 13.2 Sep 26, 2021
@iCrawl iCrawl merged commit a06a87a into discordjs:main Sep 26, 2021
@iShibi iShibi deleted the fetch-user-stuff branch January 12, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

Assignees
No one assigned
Labels
refactor semver:minor
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iShibi @vladfrangu @iCrawl @SpaceEEC