fix: Handle message bulk delete and thread delete in collectors #6902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
approved these changes
Oct 27, 2021
ImRodry
suggested changes
Oct 27, 2021
vladfrangu
previously requested changes
Oct 27, 2021
iCrawl
approved these changes
Oct 27, 2021
|
Thread deletion was additionally not being checked for in these collectors, so I've gone ahead and added them in except for interaction collectors. Interaction collectors seem to be very difficult to work with due to allowing raw messages & having all options optional, so I've opened up #6905. |
Jiralite
changed the title
kyranet
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
If the bound message to a collector was deleted from
messageDeleteBulk, the collector will still have bound listeners. This should resolve #6895.Status and versioning classification: