fix(GuildAuditLog): Remove Promises in constructor
#7089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested review from
vladfrangu,
kyranet,
suneettipirneni and
iCrawl
kyranet
approved these changes
Dec 9, 2021
suneettipirneni
requested changes
Dec 9, 2021
vladfrangu
approved these changes
Dec 11, 2021
iCrawl
approved these changes
Dec 13, 2021
thebigwolfy
approved these changes
Dec 13, 2021
SpaceEEC
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
The constructor shouldn't be utilising
Promises, so I've removed them by checking the cache and defaulting to creating anInvite.changesalso includedchannel_id&inviter_idwhich weren't being stored in theInviteclass. I think this would be a loss if we don't expose that data as at least the developer can fetch the user/resolve the channel themselves as full objects are not sent across.Status and versioning classification: