Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GuildAuditLogs): Remove static build method #7704

Merged
merged 1 commit into from Mar 24, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
After #1660 and #7089, there are no more possible Promises in the constructor of GuildAuditLogs and GuildAuditLogsEntry. Therefore, this method is redundant.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@iCrawl
Copy link
Member

iCrawl commented Mar 24, 2022

This needs a rebase.

@Jiralite Jiralite force-pushed the refactor/remove-audit-build branch from db9e6b3 to 295e177 Compare March 24, 2022 20:29
@iCrawl iCrawl merged commit cedd053 into discordjs:main Mar 24, 2022
@Jiralite Jiralite deleted the refactor/remove-audit-build branch March 24, 2022 21:23
Jiralite added a commit to suneettipirneni/guide that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants