Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildMember): Add timeouts #7104

Merged
merged 41 commits into from Dec 22, 2021
Merged

feat(GuildMember): Add timeouts #7104

merged 41 commits into from Dec 22, 2021

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Dec 12, 2021 •
edited

Description

Checklist

  • Add communication_disabled_until property in the GuildMember class
  • Support modifying communication_disabled_until in GuildMemberManager#edit()
    • Add helper method(s) to GuildMember
  • Add MODERATE_MEMBERS permission
  • Add necessary checks to permission helpers

Classification

  • Code changes have been tested against the Discord API
  • Typings have been updated
  • This pull request changes the library's interface

@Glazelf Glazelf mentioned this pull request Dec 12, 2021
Closed
5 tasks
@Jiralite Jiralite marked this pull request as draft December 12, 2021 18:18
ToasterSticks
ToasterSticks reviewed Dec 12, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
@lostful

This comment has been minimized.

Sign in to view
@ImRodry

This comment has been minimized.

Sign in to view
@lostful

This comment has been minimized.

Sign in to view
@Glazelf

This comment has been minimized.

Sign in to view
kyranet
kyranet requested changes Dec 21, 2021
View reviewed changes
src/structures/GuildMember.js Outdated Show resolved Hide resolved
@ProbablyRaging ProbablyRaging mentioned this pull request Dec 22, 2021
Closed
32 tasks
Syjalo
Syjalo suggested changes Dec 22, 2021
View reviewed changes
src/structures/BaseGuildVoiceChannel.js Outdated Show resolved Hide resolved
@Jiralite
Copy link
Member Author

I believe that's all permission checks done. Feel free to re-review!

kyranet
kyranet requested changes Dec 22, 2021
View reviewed changes
src/structures/ThreadChannel.js Outdated Show resolved Hide resolved
ImRodry
ImRodry suggested changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@ImRodry ImRodry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could GuildMember#moderatable be added?

src/structures/ThreadChannel.js Outdated Show resolved Hide resolved
TheCreativeGod
TheCreativeGod suggested changes Dec 22, 2021
View reviewed changes
Copy link

@TheCreativeGod TheCreativeGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if we can use a single return adding the timeout with specific permissions

src/structures/BaseGuildVoiceChannel.js Outdated Show resolved Hide resolved
src/structures/ThreadChannel.js Outdated Show resolved Hide resolved
src/structures/VoiceChannel.js Outdated Show resolved Hide resolved
@Jiralite
Copy link
Member Author

See if we can use a single return adding the timeout with specific permissions

Sure, but Prettier would want these to be on multiple lines anyway. I'll do it nonetheless.

@iCrawl iCrawl merged commit aa7c1b2 into discordjs:main Dec 22, 2021
@Jiralite Jiralite deleted the timeouts branch December 22, 2021 16:55
@S222em S222em mentioned this pull request Dec 25, 2021
Merged
@muchnameless muchnameless mentioned this pull request Dec 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sasiko Sasiko Sasiko left review comments

@ckohen ckohen ckohen left review comments

@oq-x oq-x oq-x left review comments

@suneettipirneni suneettipirneni suneettipirneni requested changes

@meister03 meister03 meister03 left review comments

@ToasterSticks ToasterSticks ToasterSticks left review comments

@ImRodry ImRodry ImRodry requested changes

@xHyroM xHyroM xHyroM left review comments

@almeidx almeidx almeidx left review comments

@TheCreativeGod TheCreativeGod TheCreativeGod requested changes

@Syjalo Syjalo Syjalo requested changes

@ThaTiemsz ThaTiemsz ThaTiemsz requested changes

@thebigwolfy thebigwolfy thebigwolfy approved these changes

@Mysterious-Dev Mysterious-Dev Mysterious-Dev approved these changes

@mafineeek mafineeek mafineeek approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

Assignees
No one assigned
Labels
api support discord semver:minor
Projects
discord.js
Archived in project
Milestone
Version 13.4
Development

Successfully merging this pull request may close these issues.

Add support for GuildMember timeout