New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add components to /builders #7195
feat: add components to /builders #7195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Can you not implement something similar to application command options (relating to the toJSON() being mostly {...this}?
I can, I just didn't know if handling snake_case like this:
was preferred or not |
It's what I did for builders (and subsequently forgot to do consistently), but CC @discordjs/the-big-4 about this |
Also I just realized that if there are snake_case keys, and you do |
Just replace all camelCase props on the class with snake_case 🦐 |
This needs a rebase. |
5a309aa
to
c7c3b74
Compare
c7c3b74
to
3c64f74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the changes to the yarn.lock file intentional? 👀
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
f30bd19
to
8da4109
Compare
Note: CI failing because of voice tests |
Please describe the changes this PR makes and why it should be merged:
Adds all current component types to
/builders
.Status and versioning classification: