Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove djs components and use /builders components instead #7252

Merged
merged 7 commits into from
Jan 17, 2022
Merged

refactor: remove djs components and use /builders components instead #7252

merged 7 commits into from
Jan 17, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Jan 11, 2022 •
edited by SpaceEEC

Please describe the changes this PR makes and why it should be merged:

Components from builders are reexported for convenience.

Prerequisite:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@suneettipirneni suneettipirneni marked this pull request as draft January 11, 2022 21:58
@suneettipirneni suneettipirneni marked this pull request as ready for review January 13, 2022 16:44
@iCrawl iCrawl added this to the discord.js v14 milestone Jan 13, 2022
@iCrawl
Copy link
Member

iCrawl commented Jan 13, 2022

Still having linting errors here.

@kyranet
Copy link
Member

kyranet commented Jan 14, 2022

Please rebase, you have merge conflicts.

@iCrawl
Copy link
Member

iCrawl commented Jan 14, 2022

This needs a rebase.

@suneettipirneni @vladfrangu
Update packages/discord.js/src/structures/Message.js
6ad7baa 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@suneettipirneni
Copy link
Member Author

suneettipirneni commented Jan 15, 2022 •
edited

Don't merge yet, there's a performance pitfall that I need to address that occurs in the MessagePayload serialization. I'll fix this soon.

@iCrawl iCrawl merged commit 101d7c5 into discordjs:main Jan 17, 2022
@suneettipirneni suneettipirneni deleted the refactor/builder-components branch February 7, 2022 16:24
@Jiralite Jiralite mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imranbarbhuiya imranbarbhuiya imranbarbhuiya left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:major
Projects
discord.js
Archived in project
Milestone
discord.js v14
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@suneettipirneni @iCrawl @kyranet @vladfrangu @SpaceEEC @imranbarbhuiya